Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port grafana/loki#9831 to loki.source.file #6158

Closed
rfratto opened this issue Jan 15, 2024 · 2 comments · Fixed by #6564
Closed

Port grafana/loki#9831 to loki.source.file #6158

rfratto opened this issue Jan 15, 2024 · 2 comments · Fixed by #6564
Assignees
Labels
bug Something isn't working frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.

Comments

@rfratto
Copy link
Member

rfratto commented Jan 15, 2024

@cstyan pointed out that a new bugfix got merged to Promtail (grafana/loki#9831), and that we may need to port it.

We need to investigate whether the bugfix needs to be ported, and port it if it's relevant. If it's not relevant to our code, we can close this issue.

@hainenber
Copy link
Contributor

I digged in and yes, the Agent does need this bugfix since it used Promtail instance in this chain
Promtail -> TargetManagers -> FileTargetManager -> targetSyncer -> FileTarget

@tpaschalis tpaschalis added the bug Something isn't working label Feb 21, 2024
@thampiotr thampiotr self-assigned this Feb 27, 2024
@thampiotr
Copy link
Contributor

Did some more digging and it seems we'll need to add an equivalent logic and tests here:

exclude := w.getExcludePath()

@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Apr 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants