Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.3's strict YAML parsing uncovered a typo in agent.yaml #77

Closed
jgraettinger opened this issue May 20, 2020 · 2 comments · Fixed by #78
Closed

v0.3's strict YAML parsing uncovered a typo in agent.yaml #77

jgraettinger opened this issue May 20, 2020 · 2 comments · Fixed by #78
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.

Comments

@jgraettinger
Copy link

agent/production/kubernetes/agent.yaml

Line 171 in 3cbb06b

metric_label_configs:

Should be metric_relabel_configs instead, I believe?
@rfratto
Copy link
Member

rfratto commented May 20, 2020 •
edited

Yep, you're totally right. #71 fixed part of this but we didn't update the Kubernetes YAML to include the change. I'll open a PR to fix this and do a release tomorrow to include the fix.

Thanks for reporting!

@rfratto rfratto mentioned this issue May 20, 2020
Merged
@rfratto
Copy link
Member

rfratto commented May 20, 2020

Hi @jgraettinger, I just released v0.3.1 that includes the fix for this. Thanks again!

@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 26, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

re-render Kubernetes manifest to include fix from #71 rfratto/agent
2 participants
@jgraettinger @rfratto