Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics scraping: UserAgent reports "Prometheus/v0.x" #910

Closed
bboreham opened this issue Sep 13, 2021 · 1 comment · Fixed by #1274
Closed

Metrics scraping: UserAgent reports "Prometheus/v0.x" #910

bboreham opened this issue Sep 13, 2021 · 1 comment · Fixed by #1274
Assignees
@rfratto
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. keepalive Never close from staleness

Comments

@bboreham
Copy link
Contributor

I noticed in logs User-Agent: Prometheus/v0.17.0 (using Grafana Agent 0.17.0).
IMO it should say GrafanaAgent not Prometheus.

From what I see in the code, Grafana Agent sets its own name for Prometheus remote storage and for logs, but not for scraping.
@rfratto rfratto added the keepalive Never close from staleness label Sep 13, 2021
@rfratto
Copy link
Member

rfratto commented Sep 13, 2021

Thanks, nice catch. I opened a PR upstream (prometheus/prometheus#9333) to allow us to customize the UserAgent header.

@rfratto rfratto self-assigned this Oct 21, 2021
@tpaschalis tpaschalis mentioned this issue Jan 14, 2022
Merged
3 tasks
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rfratto rfratto

Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. keepalive Never close from staleness
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set custom User-Agent header when scraping metrics tpaschalis/agent
2 participants
@rfratto @bboreham