Skip to content
This repository has been archived by the owner on Apr 26, 2021. It is now read-only.

align config endpoint with cortex, include templates #3

Merged
merged 2 commits into from
Feb 19, 2021

Conversation

domasx2
Copy link
Collaborator

@domasx2 domasx2 commented Feb 18, 2021

aling alertmanager config endpoint with cortex, adding template files

@@ -1285,12 +1286,6 @@
"type": "object",
"title": "Receiver configuration provides configuration on how to contact a receiver.",
"properties": {
"GrafanaManagedReceivers": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see GrafanaManagedReceivers among the other receivers in the generated API doc.
I believe it's because of this removal.
However, after deleting the spec and creating it (in your branch without further modifications) it worked. Therefore I would suggest to push a fresh spec.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well spotted!
Regenerating spec.json does not change it for me though :/ maybe different version of go-swagger... I installed from apt, could be old. investigating

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swagger version
version: v0.26.1
commit: a60e1e0eb8702251450c7210177289e33d067ffc

But to be honest I don't remember how I have installed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same one! super odd

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seeems if there's a stuct with similar name in both current package and an imported one, swagger does not know which one to pick. Renamed a few structs to get it to work stably

@domasx2 domasx2 merged commit 2eeceb9 into master Feb 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants