This repository has been archived by the owner on Apr 26, 2021. It is now read-only.
Move PostableUserConfig validation to this library #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gotjosh
commented
Apr 9, 2021
papagian
approved these changes
Apr 9, 2021
owen-d
approved these changes
Apr 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had this validation as part https://github.com/grafana/grafana/blob/master/pkg/services/ngalert/notifier/config.go#L85-L96.
While doing some work around the area, I realised that this validation was not being enforced at an API level. Given the API already serializes this struct before it reaches the internal library.
It feels like it belongs here after all.