This repository has been archived by the owner on Apr 26, 2021. It is now read-only.
get/set folder permission routes #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-d
approved these changes
Feb 18, 2021
papagian
reviewed
Feb 18, 2021
pkg/api/folders.go
Outdated
| "github.com/grafana/grafana/pkg/api/dtos" | ||
| ) | ||
|
|
||
| // swagger:route GET /api/v1/folder/{Id}/permissions Folders RouteGetFolderPermissions |
There was a problem hiding this comment.
Can we change it to UID? In grafana API we use UIDs for identification.
There was a problem hiding this comment.
there are no UUIDS in prom/cortex API for namespaces, just the namespace name. So I think we'll have to use that (as id)
There was a problem hiding this comment.
grafana folders have also an Id (int) field so that parameter name would be confusing for the grafana users.
There was a problem hiding this comment.
hmm, what do you suggest? {Namespace}? {Folder}?
domasx2
force-pushed
the
domas/folder-permissions
branch
from
d4d478c
to
bad13af
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two routes to get /set folder permissions.
This is rather naive, using hte same model from grafana as payload and return body.
I see that grafana returns a lot more stuff with GET ,some related to dasboards only. Not sure that we should or can have all that right now