This repository has been archived by the owner on Apr 26, 2021. It is now read-only.
make ruler json again #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papagian
approved these changes
Feb 19, 2021
papagian
reviewed
Feb 19, 2021
Comment on lines
+102
to
+104
| Record string `yaml:"record,omitempty" json:"record,omitempty"` | ||
| Alert string `yaml:"alert,omitempty" json:"alert,omitempty"` | ||
| Expr string `yaml:"expr" json:"expr"` |
There was a problem hiding this comment.
Suggested change
| Record string `yaml:"record,omitempty" json:"record,omitempty"` | |
| Alert string `yaml:"alert,omitempty" json:"alert,omitempty"` | |
| Expr string `yaml:"expr" json:"expr"` | |
| Record interface{} `yaml:"record,omitempty" json:"record,omitempty"` | |
| Alert interface{} `yaml:"alert,omitempty" json:"alert,omitempty"` | |
| Expr interface{} `yaml:"expr" json:"expr"` |
I think it's better to use interface{} to denote that it's not just a string but a YAML or JSON formatted string
but I'm fine also with the string.
There was a problem hiding this comment.
what do you mean by YAML or JSON formatted string?
afaik recrod and alert are rule names, and expr is a promql query
There was a problem hiding this comment.
I'll merge it for now, but let's discuss later
There was a problem hiding this comment.
afaik recrod and alert are rule names, and expr is a promql query
my bad; I got it wrong
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.