Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Drone CI (test and lint) plus include dependencies #12

Merged
merged 7 commits into from
Jul 18, 2022

Conversation

gotjosh
Copy link
Collaborator

@gotjosh gotjosh commented Jul 18, 2022

I've added a few things to the make file to make managing the health of this codebase a bit easier:

  • linting
  • test running
  • spellchecking of README
  • a check to make sure we avoid circular dependencies between repositories (Specifically Mimir and Grafana)

NB: The test and linting are all failing and that's expected - I'm not going to fix it as part of this PR and want instead to just put the CI/CD pipeline in place.

Copy link
Member

@JohnnyQQQQ JohnnyQQQQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2022

CLA assistant check
All committers have signed the CLA.

@gotjosh gotjosh merged commit b9c46bb into main Jul 18, 2022
@gotjosh gotjosh deleted the add-ci-and-gomod branch July 18, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants