Appease the linter and document the MaintenanceOptions interface. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gotjosh
force-pushed
the
appease-linter-doc-interface
branch
from
0578272
to
da58420
Compare
gotjosh
force-pushed
the
appease-linter-doc-interface
branch
from
da58420
to
df0185d
Compare
gotjosh
commented
Jul 18, 2022
| @@ -0,0 +1,28 @@ | |||
| {{Subject .Subject "{{.Title}}"}} | |||
There was a problem hiding this comment.
These are copied as is, for now, we'll have to re-visit all templates as we unify so don't read too much into it.
gotjosh
commented
Jul 18, 2022
| @@ -19,7 +19,7 @@ lint: .tools/bin/misspell .tools/bin/faillint .tools/bin/golangci-lint | |||
| golangci-lint run | |||
|
|
|||
| # Ensure no blocklisted package is imported. | |||
| faillint -paths "github.com/grafana/grafana,github.com/grafana/mimir" ./... # We should not have circular dependencies. | |||
| # faillint -paths "github.com/grafana/grafana/...,github.com/grafana/mimir/..." ./... # We should not have circular dependencies. | |||
There was a problem hiding this comment.
I've disabled this temporarily as there's just too many failures to tackle in one PR, but this is my no.1 priority now.
yuri-tceretian
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix all the failing lint and tests to make sure we have a working CI as a basis.