Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the BuildReceiverIntegrationsFunc to be injected as part of the config #34

Merged
merged 3 commits into from
Jan 11, 2023
Merged

Allow the BuildReceiverIntegrationsFunc to be injected as part of the config #34

merged 3 commits into from
Jan 11, 2023

Conversation

gotjosh
Copy link
Collaborator

@gotjosh gotjosh commented Jan 10, 2023 •
edited

Also backports a very small change to skip the NamespaceUIDLabel when processing alerts.

@gotjosh gotjosh changed the title Allow the BuildReceiverIntegrationsFunc to be inject as part of the config Allow the BuildReceiverIntegrationsFunc to be injected as part of the config Jan 11, 2023
@gotjosh gotjosh marked this pull request as ready for review January 11, 2023 18:30
yuri-tceretian
yuri-tceretian approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@yuri-tceretian yuri-tceretian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gotjosh gotjosh merged commit d33ca88 into main Jan 11, 2023
@gotjosh gotjosh deleted the build-receiver-integrations-func branch January 11, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuri-tceretian yuri-tceretian yuri-tceretian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gotjosh @yuri-tceretian