Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alerting: Separate exprs in default template #35

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Alerting: Separate exprs in default template #35

merged 1 commit into from
Jan 11, 2023

Conversation

grobinson-grafana
Copy link
Contributor

This pull request changes the default template to show Exprs separate from Value, as Exprs can be quite verbose.

Before this change:

Value: A=1234 sum(rate(metric[5m])), B=5678 mean(A)

After this change:

Exprs:
 - A = sum(rate(metric(5m))
 - B = mean(A)
Value: A=1234, B=5678

@grobinson-grafana grobinson-grafana requested a review from a team January 11, 2023 10:46
@grobinson-grafana grobinson-grafana self-assigned this Jan 11, 2023
@CLAassistant
Copy link

CLAassistant commented Jan 11, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

alexmobo
alexmobo approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@alexmobo alexmobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grobinson-grafana grobinson-grafana merged commit 4e67b2a into main Jan 11, 2023
@grobinson-grafana grobinson-grafana deleted the grobinson/separate-exprs-in-default-template branch January 11, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmobo alexmobo alexmobo approved these changes

Assignees

@grobinson-grafana grobinson-grafana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grobinson-grafana @CLAassistant @alexmobo