Kafka Contact Point: Fix v3 API URL when used against a Kafka Rest Proxy #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for addressing this problem! Now we just need to add a hint to users to use |
ghost
marked this pull request as ready for review
Yep! On it! |
ghost
changed the title
|
Updated the UI here: grafana/grafana@412278f |
yuri-tceretian
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Support for using v3 APIs when producing to kafka was added in this PR: #28
However, I only tested this against a Confluent Kafka Cluster from confluent.io
Turns out that the API paths are slightly different for the Kafka Rest Proxy and the confluent kafka cluster. Thanks @yuri-tceretian for bringing this to my attention!
This commit fixes the URL to work with the Kafka Rest Proxy. Confluent Kafka users can make use of this by add a "/kafka" suffix to the endpoint. We will add this as a hint on the UI.
Testing