Refactor notifier package #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move services to deciated packages split configurations and implementations
|
Discussed this offline with Yuri. We're moving into a different more aggressive direction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During moving the code from Grafana repository I moved all pieces with as little changes as possible persisting the history. Now the switch is done and it is time to take it apart.
This PR moves logger, imageStorage, templates, configs and clients (a sender that sends webhook and email) to dedicated packages.
All receiver configs are moved to the config package (similar to Alertamanager structure).
Also, it copies a factory from https://github.com/grafana/grafana/blob/f990be58cbfe8635d4970e97e4a4fb63a9e1997c/pkg/services/ngalert/notifier/channels_config/factory.go
which will let us move more code from Grafana to alerting
NOTE: the diff does not really make sense but the new dir structure is.