Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ProcessNotifierError public #45

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Make ProcessNotifierError public #45

merged 1 commit into from
Jan 19, 2023

Conversation

gotjosh
Copy link
Collaborator

@gotjosh gotjosh commented Jan 19, 2023 •
edited

It is needed as part of the API (and its tests) on Grafana.

fixes #39

@gotjosh
Make ProcessNotifierError public
dd38957 
It is needed as part of the API (and its tests) on Grafana.
@gotjosh gotjosh requested review from a team and removed request for a team January 19, 2023 19:17
alexweav
alexweav approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@alexweav alexweav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p->P, lgtm

@gotjosh gotjosh merged commit 5ebb70a into main Jan 19, 2023
@gotjosh gotjosh deleted the process-notifier-error-public branch January 19, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexweav alexweav alexweav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make processNotifierError public
2 participants
@gotjosh @alexweav