Add CustomDetails field to PagerDuty #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems there is also some handling of this field that prometheus does, and our notifier does not seem to do. Specifically, if the overall request is too big and will be rejected by PD, it makes sure to trim the custom details before anything else. If we are going to make this field editable, let's consider handling it the same way? |
santihernandezc
deleted the
santihernandezc/add_custom_details_to_pagerduty
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables users to add custom details to their PagerDuty integrations.
This field is an object containing arbitrary key-value pairs (docs). The field name is
custom_details, as shown in the example payload in PagerDuty's docs.These details get merged with the default ones we're already sending. In case of a duplicate key, the user-defined value for that key prevails.
Note: we should consider using a
map[string]interface{}instead ofmap[string]stringas we're currently doing. In the example I linked above, it's clear that the values in this object may not be always strings.