Rename image.ImageStore to image.Provider #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuri-tceretian
approved these changes
Apr 26, 2023
alexweav
reviewed
Apr 26, 2023
santihernandezc
changed the title
yuri-tceretian
approved these changes
Apr 26, 2023
santihernandezc
deleted the
santihernandezc/rename_image_store_to_image_provider
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames our
images.ImageStoretoimages.Providerfor two main reasons:grafana/grafanalikeImageStore(which interacts with the DB) andImageService.This interface will be refactored to support the use cases described in https://github.com/grafana/alerting-squad/issues/480
The number of modified files is pretty big, but this is just a rename, no functionality has been changed.