Helm: make controller namespace configurable

[csandanov]

Right now, alloy controller in Helm always deployed into default namespace, despite other resources it relies on, such as service account, use release namespace. The deployment fails as a result. This PR uses the default namespace from helpers

[CLAassistant]

All committers have signed the CLA.

[tpaschalis]

Hey there, thank you for opening a PR on the Alloy repo!

Could you explain more about what we're trying to achieve here? Did you have an issue with the Alloy helm chart itself, or the k8s-monitoring-helm chart?

Right now, alloy controller in Helm always deployed into default namespace, despite other resources it relies on

In my use clusters, the chart does respect the value I pass to helm commands eg. helm upgrade --install --namespace=alloy ...... Was that not the case for you?

[csandanov]

You're right, it actually works to my surprise.

I'm using helm but not Helm CLI and turns out Helm has some very obscure way to override namespace (via kube client config) during helm install/upgrade (but not helm template) even when they're not set (ref helm/helm#3553).

I'm playing with https://github.com/grafana/k8s-monitoring-helm and I just noticed that there are more resources in alloy's helm that do not have namespace but because k8s-monitoring does not use it I didn't notice, worth noting k8s-monitoring's templates do have metadata.namespace in their templates.

I still think it's better to specify namespace explicitly in the templates.

[github-actions]

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!