WIP: Magefile POC #819
Draft
WIP: Magefile POC #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdurham
commented
May 10, 2024
| GO_TAGS="netgo builtinassets promtail_journal_enabled" \ | ||
| GOEXPERIMENT=${GOEXPERIMENT} \ | ||
| make alloy | ||
| RUN ./build-linux-amd64 alloy |
There was a problem hiding this comment.
Need to add this back in once I tighten everything up
|
This PR has not had any activity in the past 30 days, so the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is 70% of our makefile implemented as Magefile, there are three binaries that allow you to run different targets. Two for osx and one for linux amd64. More can be added. Wanted to get thoughts before diving in deeper. I havent implemented the build cache fully so that is a todo. Tested that I can build all the binaries, boring crypto and images. Ideally the makefile becomes one command, the one to build the magefiles.
Its also debuggable! There is still some code to clean up but thought I would get some input before diving back in.