Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(otelcol): allow overriding debug metric level for all otelcol components #825

Merged
merged 13 commits into from
May 28, 2024
Merged

feat(otelcol): allow overriding debug metric level for all otelcol components #825

merged 13 commits into from
May 28, 2024

Conversation

hainenber
Copy link
Contributor

@hainenber hainenber commented May 10, 2024 •
edited

PR Description

  • Allow overriding debug metrics level for all otelcol.* components
  • Add and implement DebugMetrics as imethod for all otelcol.* Argument interface
  • Add doc ref to debug_metrics block for all otelcol.* components
  • Implement argument defaulter for DebugMetricsArg for missing OtelCol components

Which issue(s) this PR fixes

Closes #792

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@hainenber hainenber marked this pull request as ready for review May 12, 2024 03:38
@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label May 13, 2024
@clayton-cornell clayton-cornell requested a review from a team May 13, 2024 16:57
@rfratto rfratto added the backport-to-agent:no PR should NOT be backported to the agent repo. label May 14, 2024
ptodev
ptodev reviewed May 15, 2024
View reviewed changes
Copy link
Contributor

@ptodev ptodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, such a big PR! 😅 Thank you very much! It looks good and I only left a few minor comments.

docs/sources/reference/components/otelcol.auth.basic.md Outdated Show resolved Hide resolved
internal/component/otelcol/config/config_debug_metrics.go Outdated Show resolved Hide resolved
docs/sources/shared/reference/components/otelcol-debug-metrics-block.md Outdated Show resolved Hide resolved
internal/component/otelcol/config/config_debug_metrics.go Outdated Show resolved Hide resolved
@hainenber hainenber force-pushed the allow-override-debug-metric-level-for-otelcol-components branch from 45e98d7 to f81140c Compare May 16, 2024 15:29
ptodev
ptodev reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@ptodev ptodev left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I left a comment with what I believe is the only thing left to polish. I'd be happy to merge it afterwards :)

docs/sources/reference/components/otelcol.auth.bearer.md Outdated Show resolved Hide resolved
hainenber and others added 13 commits May 28, 2024 11:15
@hainenber @ptodev
feat(otelcol): allow overriding debug metric level for all components…
4ec8670 
… except `auth.* due to cyclic imports

Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber @ptodev
refactor(otelcol): decouple debug_metrics block from otelcol package
73cf006 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber @ptodev
feat(otelcol/auth): allow overriding debug metric level for `otelcol.…
74264a2 
…auth` components

Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber @ptodev
fix(otelcol): set correct test expectation for default debug metrics …
808175c 
…level

Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber @ptodev
fix(ci): add missing cfg conversion for debug metrics in `otelcolconv…
dee3afd 
…ert`

Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber @ptodev
docs: add ref to debug_metrics block for all otelcol.* components
00a340a 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber @clayton-cornell @ptodev
Apply suggestions from Clayton's code review
1f60c30 
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
@hainenber @ptodev @clayton-cornell
Apply suggestions from code review
7f890ee 
Co-authored-by: Paulin Todev <paulin.todev@gmail.com>
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
@hainenber @ptodev
fix(otelcol): return error for failed conversion of debug metric level
364811e 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber @ptodev
doc(otelcol/debug-metrics): move possible values for level outside …
86ae0a0 
…of arg table

Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber @ptodev
fix(otelcol): set default debug metric config for all missing OtelCol…
0594b95 
… components

Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber @ptodev
doc: display possible values for debug metrics level with double quot…
388a8de 
…ation

Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber @ptodev
doc: reduce padding space for debug_metrics table entry
865d061 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@ptodev ptodev force-pushed the allow-override-debug-metric-level-for-otelcol-components branch from d2b0d41 to 865d061 Compare May 28, 2024 10:19
@ptodev ptodev merged commit 7902416 into grafana:main May 28, 2024
15 checks passed
@hainenber hainenber mentioned this pull request May 29, 2024
Closed
1 task
@ptodev ptodev mentioned this pull request May 30, 2024
Merged
@hainenber hainenber deleted the allow-override-debug-metric-level-for-otelcol-components branch May 30, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptodev ptodev ptodev approved these changes

@clayton-cornell clayton-cornell clayton-cornell approved these changes

Assignees
No one assigned
Labels
backport-to-agent:no PR should NOT be backported to the agent repo. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Each otelcol component should be able to override its debug metrics level
4 participants
@hainenber @ptodev @clayton-cornell @rfratto