-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(prometheus/scrape): add example for K8s auth #829
Merged
clayton-cornell
merged 3 commits into
grafana:main
from
hainenber:prometheus-scrape-example-for-k8s-auth
May 14, 2024
Merged
docs(prometheus/scrape): add example for K8s auth #829
clayton-cornell
merged 3 commits into
grafana:main
from
hainenber:prometheus-scrape-example-for-k8s-auth
May 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hainenber <dotronghai96@gmail.com>
clayton-cornell
added
the
type/docs
Docs Squad label across all Grafana Labs repos
label
May 13, 2024
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
clayton-cornell
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more minor tweak and we should be able to merge this one :-)
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
May 14, 2024
* docs(prometheus/scrape): add example for K8s auth Signed-off-by: hainenber <dotronghai96@gmail.com> * Apply suggestions from Clayton's code review Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> * Apply suggestions from 2nd Clayton's code review Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> --------- Signed-off-by: hainenber <dotronghai96@gmail.com> Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> (cherry picked from commit d8831a5)
github-actions bot
pushed a commit
that referenced
this pull request
May 14, 2024
* docs(prometheus/scrape): add example for K8s auth Signed-off-by: hainenber <dotronghai96@gmail.com> * Apply suggestions from Clayton's code review Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> * Apply suggestions from 2nd Clayton's code review Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> --------- Signed-off-by: hainenber <dotronghai96@gmail.com> Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> (cherry picked from commit d8831a5)
clayton-cornell
pushed a commit
that referenced
this pull request
May 14, 2024
* docs(prometheus/scrape): add example for K8s auth Signed-off-by: hainenber <dotronghai96@gmail.com> * Apply suggestions from Clayton's code review Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> * Apply suggestions from 2nd Clayton's code review Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> --------- Signed-off-by: hainenber <dotronghai96@gmail.com> Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> (cherry picked from commit d8831a5) Co-authored-by: Đỗ Trọng Hải <41283691+hainenber@users.noreply.github.com>
clayton-cornell
pushed a commit
that referenced
this pull request
May 14, 2024
* docs(prometheus/scrape): add example for K8s auth Signed-off-by: hainenber <dotronghai96@gmail.com> * Apply suggestions from Clayton's code review Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> * Apply suggestions from 2nd Clayton's code review Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> --------- Signed-off-by: hainenber <dotronghai96@gmail.com> Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> (cherry picked from commit d8831a5) Co-authored-by: Đỗ Trọng Hải <41283691+hainenber@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport release/v1.0
backport release/v1.1
backport-to-agent
PR should be backported to the agent repo.
type/docs
Docs Squad label across all Grafana Labs repos
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Which issue(s) this PR fixes
Closes #827
Notes to the Reviewer
PR Checklist