Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design document for Alloy proposal process (#908) #909

Merged
merged 27 commits into from
Jun 14, 2024

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented May 22, 2024

This PR creates a design document for #908.

To demonstrate the proposed process, the design document follows the procedures laid out in the proposal itself.

@rfratto rfratto changed the title Create design doc for #918 Create design doc for #908 May 22, 2024
@rfratto rfratto changed the title Create design doc for #908 Design document for Alloy proposal process (#908) May 22, 2024
@rfratto
Copy link
Member Author

rfratto commented May 28, 2024

Original discussion can be found at #908.

@rfratto rfratto added the proposal A proposal for new functionality. label May 28, 2024
@rfratto
Copy link
Member Author

rfratto commented May 28, 2024

@erikbaranowski @tpaschalis @mattdurham Does the current state of the design document address all of your concerns?

@wildum ping on the current state just to make sure you're still comfortable with everything here.

@thampiotr I know you had some concerns with the proposed process. Is the current state better? What changes would you like to see?

docs/design/908-proposal-process.md Outdated Show resolved Hide resolved
docs/design/908-proposal-process.md Show resolved Hide resolved
docs/design/908-proposal-process.md Show resolved Hide resolved
docs/design/908-proposal-process.md Outdated Show resolved Hide resolved
docs/design/908-proposal-process.md Outdated Show resolved Hide resolved
docs/design/908-proposal-process.md Show resolved Hide resolved
@rfratto
Copy link
Member Author

rfratto commented Jun 5, 2024

@ptodev Checking in, what's your current feeling on this proposal?

@ptodev
Copy link
Contributor

ptodev commented Jun 7, 2024

@ptodev Checking in, what's your current feeling on this proposal?

@rfratto I'm very happy with it, thank you! It looks great and I'm happy for it to be merged.

@rfratto rfratto mentioned this pull request Jun 7, 2024
docs/design/908-proposal-process.md Show resolved Hide resolved
docs/design/908-proposal-process.md Show resolved Hide resolved
docs/design/908-proposal-process.md Show resolved Hide resolved
docs/design/908-proposal-process.md Outdated Show resolved Hide resolved
docs/design/908-proposal-process.md Show resolved Hide resolved
docs/design/908-proposal-process.md Outdated Show resolved Hide resolved
docs/design/908-proposal-process.md Show resolved Hide resolved
Comment on lines +357 to +359
* Discussion on issues should be done conversationally rather than responding
to individual lines of text. This can help reduce the total number of
comments and make a conversation more digestible.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned before, I find long-form essays by far less digestible than comments on individual lines of text, where all the context is available. I feel the argument in your doc is up for the debate and could actually have quite the opposite effect. A lot (if not all) modern communication tools for large groups of people support threads, so my view on this topic is also likely to be quite common.

Having said that, I'm happy that PR with design doc can become the source of truth for a more involved discussion. In fact, I would consider a policy where anything more than two threads or two rounds of technical comments should usually be migrated to a design doc PR. Worst case it'd be a short design doc.

docs/design/908-proposal-process.md Show resolved Hide resolved
docs/design/908-proposal-process.md Show resolved Hide resolved
@rfratto rfratto requested a review from thampiotr June 7, 2024 14:53
@rfratto
Copy link
Member Author

rfratto commented Jun 7, 2024

It sounds like we're at a rough consensus with the current state of this proposal, so I'll move this to Likely Accept. This marks the start of the final comment period for consensus to be changed.

If consensus hasn't changed by Friday, June 14, this proposal will become Accepted.

cc @erikbaranowski @tpaschalis @mattdurham @wildum @thampiotr @ptodev

Copy link
Contributor

@thampiotr thampiotr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to trial this. I'd like to be careful not to generate too much work for the proposers and maintainers with this. I'm sure we can adjust in the future if this becomes the case.

@rfratto
Copy link
Member Author

rfratto commented Jun 14, 2024

No change in consensus, so this proposal is now Accepted.

I will merge this and follow up on the next steps to roll this process out to other proposals.

@rfratto rfratto merged commit e0876e2 into grafana:main Jun 14, 2024
15 checks passed
@rfratto rfratto deleted the proposal-review-process branch June 14, 2024 12:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age proposal A proposal for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants