Add yaml_decode to stdlib #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildum
approved these changes
May 24, 2024
There was a problem hiding this comment.
LGTM, @rfratto is working on a proposal for the stdlib functions (see #821 (review)). I'm holding on the path_join function but maybe this one is fine because we already have json_decode?
clayton-cornell
approved these changes
May 24, 2024
rfratto
approved these changes
May 24, 2024
There was a problem hiding this comment.
LGTM, @rfratto is working on a proposal for the stdlib functions (see #821 (review)). I'm holding on the path_join function but maybe this one is fine because we already have json_decode?
I agree that since this follows the convention of the other decode function, it's likely fine to merge in advance of a proposal for fleshing out the standard library. Approving!
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This add yaml_decode to standard library, most of the work was taken from code @djcode submitted for Agent/River