add AlertService #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seeks to add a `AlertService` client for interacting with the Grafana OnCall [alerts HTTP API](https://grafana.com/docs/grafana-cloud/oncall/oncall-api-reference/alerts/). Currently, the `AlertService` has a single `ListAlerts` method used to interact with the only documented OnCall alerts endpoint. Signed-off-by: Mike Ball <mikedball@gmail.com>
mdb
commented
Jul 6, 2022
| // Alert represents an on-call alert. | ||
| type Alert struct { | ||
| ID string `json:"id"` | ||
| AlertGroupID string `json:"alert_group_id"` |
There was a problem hiding this comment.
Note that I've used all-uppercase acronyms in struct field names, as per Go convention. However, this contrasts a bit with patterns used elsewhere in amixr-api-go-client, such as OnCallShift's TeamId field.
|
Hi @Konstantinov-Innokentii - Would you mind taking a look at this? |
|
Thanks @mdb, I will take a look |
|
@Konstantinov-Innokentii Did you get a chance to take a look at this? Thanks! |
|
Hi @Ferril -- I notice you're a contributor to this codebase. Would you be willing to review in place of @Konstantinov-Innokentii ? |
|
@mdb merged PR, sorry for the long delay, got a lot on my plate now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seeks to add a
AlertServiceclient for interacting withthe Grafana OnCall alerts HTTP API.
Currently, the
AlertServicehas a singleListAlertsmethod usedto interact with the only documented OnCall alerts endpoint.