Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template variable and cql editor #14

Merged
merged 4 commits into from
Aug 30, 2022
Merged

Template variable and cql editor #14

merged 4 commits into from
Aug 30, 2022

Conversation

ktw4071
Copy link
Contributor

@ktw4071 ktw4071 commented Aug 30, 2022

@ktw4071 ktw4071 linked an issue Aug 30, 2022 that may be closed by this pull request
Support template variables #8
Closed
ktw4071
ktw4071 commented Aug 30, 2022
View reviewed changes
package.json Show resolved Hide resolved
@ktw4071 ktw4071 self-assigned this Aug 30, 2022
This was linked to issues Aug 30, 2022
Add VariableEditor component ( wrap CQLEditor ) #7
Closed
Support Query type variables #9
Closed
scottlepp
scottlepp approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@scottlepp scottlepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ktw4071
Copy link
Contributor Author

ktw4071 commented Aug 30, 2022

Hello @scottlepp
Could you check my comment above? There are lots of changes in go pkgs. Wasn't intentional.

@ktw4071 ktw4071 merged commit 82c9b04 into main Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottlepp scottlepp scottlepp approved these changes

@alyssabull alyssabull Awaiting requested review from alyssabull

@srclosson srclosson Awaiting requested review from srclosson

Assignees

@ktw4071 ktw4071

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Query type variables Support template variables Add VariableEditor component ( wrap CQLEditor )
2 participants
@ktw4071 @scottlepp