-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for Framer #22
Tests for Framer #22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Updated this task to include types here that are null.
// | Labels: | Labels: | Labels: | Labels: | Labels: | Labels: | Labels: | Labels: | Labels: | Labels: | Labels: | Labels: | Labels: | Labels: | Labels: | Labels: | Labels: | Labels: | Labels: | Labels: | Labels: | Labels: | Labels: | | ||
// | Type: []*string | Type: []*string | Type: []*int64 | Type: []*string | Type: []*bool | Type: []*time.Time | Type: []*float64 | Type: []*float64 | Type: []*float64 | Type: []*string | Type: []*int64 | Type: []*string | Type: []*string | Type: []*string | Type: []*int64 | Type: []*string | Type: []*time.Time | Type: []*string | Type: []*uint64 | Type: []*int64 | Type: []*string | Type: []*string | Type: []*uint64 | | ||
// +-----------------+------------------+-------------------+-----------------+--------------------+--------------------+--------------------+-------------------+------------------+-----------------+----------------+-----------------+-----------------+-----------------+---------------------+-----------------+-----------------------------------+---------------------+-----------------+--------------------+------------------+--------------------+-------------------+ | ||
// | null | null | 1 | null | true | null | 1.1 | 2.2 | 3.3 | null | 2 | null | null | null | 3 | bravo | 2021-09-07 16:40:31.123 +0000 UTC | null | 36930123456789 | 5 | null | charlie | 4 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you sync with main blob should work now.
CREATE TABLE IF NOT EXISTS grafana.tempTable1 ( | ||
id uuid PRIMARY KEY, | ||
asciivalue ascii, | ||
textvalue text, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe fix these indents to make them consistent
This PR adds tests Frame() method and tests for various data type converters.
This is placeholder/baseline for Framer implementation. Currently, the frame returns null for various data types. Eventually this needs to be fixed via Framer implementation in subsequent PRs.
Also these tests run via container.
Example data:
queries used: