Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null collection panic #35

Merged
merged 5 commits into from
Sep 9, 2022
Merged

Null collection panic #35

merged 5 commits into from
Sep 9, 2022

Conversation

yesoreyeram
Copy link
Contributor

  • Fix null collection panic issues
  • Fix default format issue ( also moved the format determination logic to backend )

scottlepp
scottlepp approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@scottlepp scottlepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nil check we probably can remove now

pkg/plugin/converters.go Outdated Show resolved Hide resolved
@yesoreyeram yesoreyeram merged commit 1ff86a7 into main Sep 9, 2022
scottlepp
scottlepp reviewed Sep 9, 2022
View reviewed changes
Copy link
Contributor

@scottlepp scottlepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since c.Elements is an array i don't think we need to nil check it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottlepp scottlepp scottlepp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yesoreyeram @scottlepp