Re-enable annotations e2e test #198
Conversation
|
Levitate is-compatible report: 🔍 Resolving @grafana/data@latest... 🔬 Checking compatibility between ./src/module.ts and @grafana/data@9.3.2... 🔬 Checking compatibility between ./src/module.ts and @grafana/ui@9.3.2... 🔬 Checking compatibility between ./src/module.ts and @grafana/runtime@9.3.2... 🔬 Checking compatibility between ./src/module.ts and @grafana/e2e-selectors@9.3.2... ✔️ ./src/module.ts appears to be compatible with @grafana/data,@grafana/ui,@grafana/runtime,@grafana/e2e-selectors |
|
Backend code coverage report for PR #198 |
|
Frontend code coverage report for PR #198
|
| @@ -6,7 +6,7 @@ services: | |||
| build: | |||
| context: ./.config | |||
| args: | |||
| grafana_version: ${GRAFANA_VERSION:-9.1.2} | |||
There was a problem hiding this comment.
just curious if this change is necessary, seems harmless, more just curious if the e2e tests use this docker file at all
There was a problem hiding this comment.
the e2e tests that run in ci don't use this docker file, i was using this to test the e2e locally.
| @@ -37,6 +37,7 @@ export const mockDatasource = new DataSource({ | |||
| type: 'athena-datasource', | |||
| name: 'Athena Data Source', | |||
| access: 'proxy', | |||
| readOnly: false, | |||
There was a problem hiding this comment.
what did this do? I'm guessing this is just a new required field in 9.3.2?
There was a problem hiding this comment.
yea, new required field
| const regionsResponse = await ctx.ds.getRegions(); | ||
|
|
||
| expect(regionsResponse).toHaveLength(response.length); | ||
| expect(regionsResponse).toBe(response); | ||
| expect(regionsResponse).toEqual(response); |
There was a problem hiding this comment.
curious if this is the result of just a package update or if this is like meaningfully different in some way?
There was a problem hiding this comment.
the mock's response was previously set with backendSrv.get = jest.fn(() => Promise.resolve(response)); (removed line 70), but now it's set up in the beforeEach so now it's not testing for reference equality anymore.
| @@ -61,61 +56,76 @@ describe('AthenaDatasource', () => { | |||
| jsonData: { defaultRegion: 'testRegion', catalog: 'testCatalog', database: 'testDatabase' }, | |||
| } as unknown as DataSourceInstanceSettings<AthenaDataSourceOptions>; | |||
| ctx.ds = new DataSource(ctx.instanceSettings); | |||
| runtime.setBackendSrv(backendSrv as runtime.BackendSrv); | |||
| ctx.ds.getResource = jest.fn().mockImplementation((path: string) => { | |||
There was a problem hiding this comment.
why were these changes needed is setBackendSrv not a thing in the newer version? Looks good tho, just curious!
There was a problem hiding this comment.
setBackendSrv is still a thing, but after upgrading, there were errors with needing to mock fetch from the BackendSrv. i didn't want to spend time mocking out the internals of the BackendSrv.
@grafana/*packages in order to re-enable the annotations in the e2e test. Packages are updated to v9.3.2 since there were some fixes in thee2eande2e-selectorpackages that are needed for the tests to work.@grafana/aws-sdkto fix a build error whereclassNamewas not properly recognized as a prop onResourceSelectorused inQueryEditor.tsxNote: to run e2e locally, you'll need to make sure you're using and npm version < 9. For more info see grafana/grafana#59425.
Fixes: #187