Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Aggregate" and "Group by" removal logic #425

Merged
merged 1 commit into from Jul 11, 2022
Merged

Fix "Aggregate" and "Group by" removal logic #425

merged 1 commit into from Jul 11, 2022

Conversation

andresmgot
Copy link
Contributor

Fixes #403

This was a rendering issue, the right element was being removed from the array but the component didn't re-render with the new data.

Peek 2022-07-11 14-41

I am not adding tests because this code should go away once we tackle #391

@andresmgot andresmgot requested a review from a team as a code owner July 11, 2022 12:47
@andresmgot andresmgot requested review from vickyyyyyyy and yaelleC and removed request for a team July 11, 2022 12:47
@andresmgot andresmgot changed the title Fix Aggregate and Group by removal logic Fix "Aggregate" and "Group by" removal logic Jul 11, 2022
@github-actions
Copy link

Code coverage report for PR #425

Go TypeScript
main 55.5% 69.52%
PR 55.5% 69.22%
difference 0% -.30%

yaelleC
yaelleC approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@yaelleC yaelleC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andresmgot andresmgot merged commit dd22a05 into main Jul 11, 2022
@andresmgot andresmgot deleted the rmFix branch July 11, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaelleC yaelleC yaelleC approved these changes

@vickyyyyyyy vickyyyyyyy Awaiting requested review from vickyyyyyyy vickyyyyyyy is a code owner automatically assigned from grafana/partner-datasources

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removing column in group by clause removes the last one and not the selected one
2 participants
@andresmgot @yaelleC