Refactor: define join element rather than indexes in the FilterList #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Backend code coverage report for PR #477 |
|
Frontend code coverage report for PR #477
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying the suggestion at grafana/grafana#55664 (comment)
Rather than adding the
indexto the List type and conditionally render the "OR" label within an Item, this PR adds thetypeof a list item, which is either anexpressionor acondition("OR" label in this case).I don't necessarily like this option better, mostly because the code is a bit messing to insert (or remove) "conditions" between "expressions", but leaving this here for reference.