Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid modifying the database schema #494

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Avoid modifying the database schema #494

merged 1 commit into from
Oct 18, 2022

Conversation

andresmgot
Copy link
Contributor

The raw query editor was modifying the schema object stored, causing the data source configuration page to show some wrong data.

Fixes #405

Note: This only fixes the new query editor, not the legacy one.

@andresmgot andresmgot marked this pull request as ready for review October 18, 2022 14:45
@andresmgot andresmgot requested a review from a team as a code owner October 18, 2022 14:45
Copy link
Contributor

@yaelleC yaelleC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that! 🚀

Copy link
Contributor

@asimpson asimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@github-actions
Copy link

Backend code coverage report for PR #494
No changes

@github-actions
Copy link

Frontend code coverage report for PR #494

Plugin Main PR Difference
src 78.79% 78.79% 0%

@andresmgot andresmgot merged commit 4b03222 into main Oct 18, 2022
@andresmgot andresmgot deleted the schemaFix branch October 18, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Macros displayed as KQL functions
3 participants