Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Use version from plugin meta info #498

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Refactor: Use version from plugin meta info #498

merged 1 commit into from
Oct 20, 2022

Conversation

andresmgot
Copy link
Contributor

The version that was being pass down was the string %VERSION% rather than the real version of the plugin.

@andresmgot andresmgot requested a review from a team as a code owner October 20, 2022 10:45
aangelisc
aangelisc approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link

github-actions bot commented Oct 20, 2022 •
edited

Levitate is-compatible report:

🔍 Resolving @grafana/data@latest...
🔍 Resolving @grafana/ui@latest...
🔍 Resolving @grafana/runtime@latest...
🔍 Resolving @grafana/e2e-selectors@latest...

🔬 Checking compatibility between ./src/module.ts and @grafana/data@9.2.1...
✔ Found @grafana/data version 9.2.1 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/ui@9.2.1...
✔ Found @grafana/ui version 9.2.1 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/runtime@9.2.1...
✔ Found @grafana/runtime version 9.2.1 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/e2e-selectors@9.2.1...
✔ Found @grafana/e2e-selectors version 9.1.5 locally

✔️ ./src/module.ts appears to be compatible with @grafana/data,@grafana/ui,@grafana/runtime,@grafana/e2e-selectors

@github-actions
Copy link

Backend code coverage report for PR #498
No changes

@github-actions
Copy link

Frontend code coverage report for PR #498

Plugin Main PR Difference
src 78.79% 78.79% 0%

@andresmgot andresmgot merged commit 322f91d into main Oct 20, 2022
@andresmgot andresmgot deleted the fixVersionTrack branch October 20, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aangelisc aangelisc aangelisc approved these changes

@asimpson asimpson Awaiting requested review from asimpson asimpson is a code owner automatically assigned from grafana/partner-datasources

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andresmgot @aangelisc