Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Grafana toolkit #521

Closed
wants to merge 1 commit into from
Closed

Add Grafana toolkit #521

wants to merge 1 commit into from

Conversation

aangelisc
Copy link
Contributor

Switching to the Grafana toolkit for plugin development requires the package to be included for the scripts to be run.

@aangelisc aangelisc requested a review from a team as a code owner November 23, 2022 14:57
@github-actions
Copy link

Backend code coverage report for PR #521
No changes

@github-actions
Copy link

Frontend code coverage report for PR #521
No changes

@andresmgot
Copy link
Contributor

which scripts? I think that the goal was to remove the grafana/toolkit in favor of the create-plugin tool

@andresmgot
Copy link
Contributor

actually you may be referring to the watch script, I thought I removed it but it's still there. We should use yarn dev now.

@aangelisc
Copy link
Contributor Author

actually you may be referring to the watch script, I thought I removed it but it's still there. We should use yarn dev now.

Ah okay, I will update this PR to remove the watch and sign scripts instead!

@aangelisc aangelisc closed this Nov 23, 2022
@aangelisc aangelisc deleted the add-grafana-toolkit branch November 23, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asimpson asimpson Awaiting requested review from asimpson asimpson is a code owner automatically assigned from grafana/partner-datasources

@andresmgot andresmgot Awaiting requested review from andresmgot andresmgot is a code owner automatically assigned from grafana/partner-datasources

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aangelisc @andresmgot