Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Alert queries for new editor and empty responses #528

Merged
merged 3 commits into from
Dec 21, 2022
Merged

Fix: Alert queries for new editor and empty responses #528

merged 3 commits into from
Dec 21, 2022

Conversation

andresmgot
Copy link
Contributor

@andresmgot andresmgot commented Dec 21, 2022 •
edited

  • If no rows are returned, return no frames. This is necessary to interpret a response as "empty" in Alerting.
  • For some reason, only in alerting, the new query builder entered in a infinity loop. This was because one useEffect was being continuosly executed even without changes.

Fixes #59348

@andresmgot andresmgot requested a review from a team as a code owner December 21, 2022 11:02
@github-actions
Copy link

Backend code coverage report for PR #528

Plugin Main PR Difference
azuredx 33.3% 33.3% 0%

@github-actions
Copy link

Frontend code coverage report for PR #528

Plugin Main PR Difference
src 81.86% 81.86% 0%

@andresmgot andresmgot merged commit 9a1b3b1 into main Dec 21, 2022
@andresmgot andresmgot deleted the alertsFix branch December 21, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aangelisc aangelisc aangelisc approved these changes

@asimpson asimpson Awaiting requested review from asimpson asimpson is a code owner automatically assigned from grafana/partner-datasources

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No data interpreted as error with ADX time series
2 participants
@andresmgot @aangelisc