Adapt e2e tests #540
Merged
Adapt e2e tests #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
commented
Jan 13, 2023
| @@ -136,18 +137,29 @@ export const AzureCredentialsForm: FunctionComponent<Props> = (props: Props) => | |||
| )} | |||
| {credentials.authType === 'clientsecret-obo' && ( | |||
| <> | |||
| {/* eslint-disable prettier/prettier */} | |||
There was a problem hiding this comment.
my editor was ignoring this so the file was re-formatted anyway.
|
Backend code coverage report for PR #540 |
|
Frontend code coverage report for PR #540
|
aangelisc
reviewed
Jan 13, 2023
cypress/integration/smoke.spec.ts
Outdated
| @@ -26,7 +26,7 @@ function addCommonProvisioningADXDatasource(ADXProvisions: ADXProvision[]) { | |||
| e2e.flows.addDataSource({ | |||
| type: 'Azure Data Explorer Datasource', | |||
| form: () => { | |||
| e2eSelectors.configEditor.azureCloud.input().type('Azure'); | |||
| e2eSelectors.configEditor.azureCloud.input().find('#azure-cloud-type').type('Azure'); | |||
There was a problem hiding this comment.
nit: I think .find('input') here is more stable rather than referencing the htmlFor field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed after #529