Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New variable query editor #560

Merged
merged 18 commits into from
Mar 17, 2023
Merged

New variable query editor #560

merged 18 commits into from
Mar 17, 2023

Conversation

aangelisc
Copy link
Contributor

@aangelisc aangelisc commented Mar 1, 2023 •
edited

This PR introduces some substantial changes to the template variable editor for the Azure Data Explorer datasource.

  • Updates the template variable editor to make use of the current ADX query editor. This allows template variable queries to either be built or queried via raw KQL.
  • Updates the template variable editor with support for predefined queries. Databases, tables, and columns.
  • Removes redundant code that made use of metricFindQuery.
  • Add support in KQL variable editor for macros and other template variables (including time related macros).
  • Update deprecated toPromise usage to lastValueFrom.
  • Update migrations to ensure any old template variables are appropriately migrated.
  • Update migrations to ensure old queries now include the queryType property.
  • Update E2E tests to improve speed and reduce repetition.
  • Bump E2E packages

Fixes #546
Fixes grafana/grafana#61509

image
image

@aangelisc
Add new variable support
57bcbb5 
- Create new variable editor component
- Add new variable query functions
- Add ADX Query type property
- Update query migrations
- Remove outdated metricFindQuery method
- Update all references to rxjs toPromise
@aangelisc
Add support for tables variables
48034f7 
- Prettify VariableEditor
- Add supporting function for retrieving variables
@aangelisc
Ordering of variable queries
e0edc91
@aangelisc aangelisc added enhancement New feature or request effort/medium changelog PRs to include in the CHANGELOG labels Mar 1, 2023
@aangelisc aangelisc self-assigned this Mar 1, 2023
@aangelisc aangelisc requested a review from a team as a code owner March 1, 2023 19:21
@github-actions
Copy link

Backend code coverage report for PR #560
No changes

@github-actions
Copy link

github-actions bot commented Mar 13, 2023 •
edited

Frontend code coverage report for PR #560

Plugin Main PR Difference
src 81.89% 84.32% 2.43%

bossinc
bossinc approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@bossinc bossinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! 🎉

@aangelisc aangelisc changed the title Update template variable feature New variable query editor Mar 17, 2023
@aangelisc aangelisc merged commit cd364d4 into main Mar 17, 2023
@aangelisc aangelisc deleted the adx-variable-updates branch March 17, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bossinc bossinc bossinc approved these changes

@asimpson asimpson Awaiting requested review from asimpson asimpson is a code owner automatically assigned from grafana/partner-datasources

Assignees

@aangelisc aangelisc

Labels
changelog PRs to include in the CHANGELOG effort/medium enhancement New feature or request
Projects
Partner Datasources
Status: Done
Milestone
No milestone
2 participants
@aangelisc @bossinc