Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve adx time series format in raw mode #562

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Preserve adx time series format in raw mode #562

merged 2 commits into from
Mar 2, 2023

Conversation

alyssabull
Copy link
Contributor

When a user refreshes the page, the KQL editor (rawMode) format option ADX Time Series is now preserved and not changed to Time Series.

Fixes #561

@alyssabull alyssabull added type/bug Something isn't working datasource/ADX labels Mar 1, 2023
@alyssabull alyssabull self-assigned this Mar 1, 2023
@alyssabull alyssabull requested a review from a team as a code owner March 1, 2023 21:57
@CLAassistant
Copy link

CLAassistant commented Mar 1, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Backend code coverage report for PR #562
No changes

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Frontend code coverage report for PR #562

Plugin Main PR Difference
src 81.89% 81.89% 0%

asimpson
asimpson reviewed Mar 2, 2023
View reviewed changes
Copy link
Contributor

@asimpson asimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll let someone else approve since we paired on it a bit 😎

aangelisc
aangelisc approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😊

@alyssabull alyssabull merged commit fddca31 into main Mar 2, 2023
@alyssabull alyssabull deleted the result-format-bug branch March 2, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asimpson asimpson asimpson left review comments

@aangelisc aangelisc aangelisc approved these changes

Assignees

@alyssabull alyssabull

Labels
datasource/ADX type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Azure Data Explorer panel editor keeps reverting "Format as" to "Time series" when I open the panel editor
4 participants
@alyssabull @CLAassistant @asimpson @aangelisc