Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spooling is broken #32

Closed
Dieterbe opened this issue Oct 15, 2014 · 6 comments
Closed

spooling is broken #32

Dieterbe opened this issue Oct 15, 2014 · 6 comments

Comments

@Dieterbe
Copy link
Contributor

broken-spooling
endpoint went down, we spool to disk, endpoint comes back up, we unspool, but not correctly: some data gets lost as can be seen.
there's usually an interleaved pattern of data that makes it back, as can be seen here.
sometimes preceeded by a period of full data loss, sometimes not.

@Dieterbe
Copy link
Contributor Author

should be fixed in master, will verify and update this

@schainker-digbil
Copy link

This does not appear to be working in master. This is a bit of a dumb question, but should we be making sure the metrics also have timestamps in order for them to spool back properly?

@Dieterbe
Copy link
Contributor Author

Dieterbe commented Dec 2, 2014

should we be making sure the metrics also have timestamps in order for them to spool back properly?

the metrics are all <key> <val> <timestamp> triplets, that's how they are sent via carbon so that's how they are stored and replayed. no issues here :)

@Dieterbe
Copy link
Contributor Author

Dieterbe commented Dec 2, 2014

you're right.
for some reason when the dest comes back up it doesn't process anything for the dest.
viulmpv
btw the git repo now has a grafana dashboard which makes it easy to see what's going on.
since cf6500c

Dieterbe pushed a commit that referenced this issue Dec 4, 2014
we used to return the newly created object, always.
even when registering failed due to prior existing objects.
this manifested itself in cases where:
* conn up, conn down, conn back up
* new conn gets new counters, but registry still contains old ones
* conn increments counters, but you don't see it in expvar or graphite
@Dieterbe
Copy link
Contributor Author

Dieterbe commented Dec 4, 2014

so the last visible issue was very much a metering problem.
that is fixed now
fix

however, there is another bug somewhere preventing metrics from properly arriving (whether after spooling or not), see #45, so we must first fix that. once that's done, we can verify spooling

@Dieterbe
Copy link
Contributor Author

since #45 is fixed (actually 45 was due to me dropping data before I sent it into the relay.. oops)
I confirmed this again. verified carbon-relay-ng's internal metrics, as well as dashboards to make sure all data displays correctly.
spooling-works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants