Updated kisielk/og-rek, data type changes due to this update and pickle.go debug info #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with some pickled data, works as intended
PS: I had an issue with some production pickled data from an outdated Java client, but upon closer inspection of the tcpdump it turned out its header is erroneously 8 bytes long (ie. it's not 4 bytes as the spec dictates), so carbon-relay-ng "correctly" detects payload size of zero upon reading the first 4 bytes and exits with EOF error.
More tests and comments welcome, of course.