support for specifying explicit prefix and/or substring filter in aggregations #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er in aggregations
DanCech
force-pushed
the
aggregationFilters
branch
from
d67199e
to
e58c9fe
Compare
Dieterbe
suggested changes
Dec 1, 2017
| } | ||
| str += "\n" | ||
| return str | ||
| return strings.Repeat("=", amount) + "\n" |
|
also, let's update the example ini file with these new options |
|
@Dieterbe changes made, can you merge? |
DanCech
changed the title
DanCech
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of an idea I had for reducing CPU usage when multiple regular-expression based aggregations are in use.
It allows the user to specify a
prefixFilterandsubstringFilterin the aggregation config, and if specified they are used inpreMatchto filter the series before passing them to the final regex. If prefixFilter isn't specified or is empty then the old behavior of deducing a prefix from the regular expression is used.