reorganize config docs #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* make default configs plain and basic. too many people have all kinds of cruft originating from the example config * instead, just document various examples * other than spool dir and pid file, docker file and default file were the same, so just merge them, as the standard file has no defined deployment model, the defaults from docker file should be OK. * bump default metric interval 1s -> 10s since that is more commonly used
|
@DanCech looks good to you? |
DanCech
reviewed
May 15, 2018
docs/config.md
Outdated
| timeout=10000 | ||
| # number of concurrent connections to use for sending data. | ||
| concurrency=100 | ||
| ``` |
There was a problem hiding this comment.
maybe comment these out if they match the defaults, in case of people just copy-pasting the entire block
DanCech
reviewed
May 15, 2018
examples/carbon-relay-ng.ini
Outdated
| 'prefix collectd.localhost', | ||
| 'regex ^foo\..*\.cpu+' | ||
| ] | ||
| # See https://github.com/graphite-ng/carbon-relay-ng/blob/master/docs/config.md#Blacklist |
There was a problem hiding this comment.
maybe keep an empty blacklist here for ease of adding entries?
blacklist = [
]
|
thanks @DanCech , did both of those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
too many people have all kinds of cruft originating from the example
config
the same, so just merge them, as the standard file has no defined
deployment model, the defaults from docker file should be OK.
used