Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

close tcp conn when done #313

Merged
merged 1 commit into from
Oct 16, 2018
Merged

close tcp conn when done #313

merged 1 commit into from
Oct 16, 2018

Conversation

Dieterbe
Copy link
Contributor

@Dieterbe Dieterbe commented Oct 16, 2018 •
edited

trivial to test locally with the default graphite_addr pointing to itself.
with master sudo netstat -antp | grep carbon-relay grows CLOSE_WAIT every second after startup.
with this branch, not the case.

@Dieterbe Dieterbe mentioned this pull request Oct 16, 2018
Closed
@Dieterbe Dieterbe changed the title WIP: close conn when done close conn when done Oct 16, 2018
@Dieterbe Dieterbe changed the title close conn when done close tcp conn when done Oct 16, 2018
@Dieterbe Dieterbe merged commit 95709b3 into master Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodsaj woodsaj woodsaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Dieterbe @woodsaj