Cleanups and logging #317
Merged
Cleanups and logging #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dieterbe
force-pushed
the
cleanups-and-logging
branch
2 times, most recently
from
771b77b
to
9777278
Compare
|
cc @robert-milan does this look to you |
* switch to logrus * have tracing be a lower level than debug, which makes sense, as tracing of individual packets is much higher volume than debug messages. * in particular, people were previously included to change the default notice to info, and getting overwhelmed with tracing data. This is now solved and the ambiguity is gone. There is no more "notice", only "info" which is now the sensible default. * the custom logger is copied from metrictank ---> If you were previously using notice, you should now use info <---
Dieterbe
force-pushed
the
cleanups-and-logging
branch
from
9777278
to
361f647
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see individual commit messages for details.
BREAKING: If you were previously using notice, you should now use info
this makes it easier to use the plugins in other projects which use logrus
fix #285