make Listener handling overrideable #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Give it access to the net.Conn when we have one. This enables it to inspect it for logging and instrumentation, opening the door for 3rd party projects that want to use our code but have their own logging and metrics approach. We still get to enjoy the code reuse optimization of having the same io.Reader-based code path for handling both conns and packets, but it is now an implementation detail rather than enforcing it via the Handler function signature. While we're at it, make logging around connections more consistent and better.
* let Handlers just focus on deserialization stuff, not networking, logging, etc. * by moving the latter into an overreable function in the Listener, we can get rid of duplication between Plain and Pickle, while still allowing 3rd parties to override what they need.
makes the construction of the listener less redundant
make Listener handling logic customizable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.