support pickle protocol versions 0, 1, 2, 3 & 4 + accept pickle arrays + send pickle tuples #341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #340
We have this check in place to drop obviosuly-invalid data sent to the pickle port, rather than trying to feed it into og-rek.
With this update we should cover all possible valid payload prefixes for pickle protocol versions 0 through 4.
To verify, you can send a test metric with a command like:
Replace
protocol=2
to test other supported versions, to use protocol 3 or 4 you need to be running python 3.x