Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makefile to correctly set file permissions #457

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

nikosmeds
Copy link
Contributor

Set example config and systemd unit file permissions to 0644, which matches their values in the examples/ directory.

This is required because install command sets all files to 0755 by default:

man install
[...]
     -m      Specify an alternate mode.  The default mode is set to rwxr-xr-x (0755).  The specified mode may be either
             an octal or symbolic value; see chmod(1) for a description of possible mode values.

Alternatively, we could opt to use cp, but the result would be the same.

Closes #440.

Copy link
Member

@trotttrotttrott trotttrotttrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dieterbe
Copy link
Contributor

thanks to both of you 😍

@Dieterbe Dieterbe merged commit 05b0fed into master Apr 26, 2021
@Dieterbe Dieterbe deleted the nikosmeds/systemd-service-file-permissions branch April 26, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debian/Ubuntu Systemd service-file has wrong mode (is executable).
3 participants