Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GrafanaNet route: periodically post schemas #458

Merged
merged 1 commit into from
May 19, 2021

Conversation

Dieterbe
Copy link
Contributor

@Dieterbe Dieterbe commented Apr 26, 2021

On the grafana cloud side, we want to know the schemas that get applied
to metrics. So we periodically post the "parsed" version of it to /metrics/schemas
which makes sure to exclude things like comments.

with an unpatched gw, we get 404 back and we handle it gracefully, retrying next time.
with a patched gw that reads the body and returns 200, it can see the schemas as expected

@Dieterbe Dieterbe force-pushed the post-schemas-grafanacloud branch 2 times, most recently from cafd23e to 7bb2164 Compare April 26, 2021 18:26
On the grafana cloud side, we want to know the schemas that get applied
to metrics.  So we periodically post the "parsed" version of it to
/metrics/schemas which makes sure to exclude things like comments.
[hello]
pattern = .*
retentions = 10m:90d,10m:365y
priority = 4294967294
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these generated priorities are a bit clunky looking but they work

@fkaleo fkaleo self-requested a review May 11, 2021 15:44
Copy link

@fkaleo fkaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good to go

@Dieterbe Dieterbe merged commit 2b8fe62 into master May 19, 2021
@Dieterbe Dieterbe deleted the post-schemas-grafanacloud branch May 19, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants