refactor grafanaNet route cfg + unit testing for setting up route + configurable retry backoff intervals + more #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because the schemas need to be delivered timely
Dieterbe
force-pushed
the
grafana-net-cfg
branch
from
f835dec
to
751b484
Compare
|
What I have seen so far (I have reviewed commits till 751b484) looks good to me. |
The table package should not reach out into configuration packages such as cfg and imperatives Instead the table is something that should be setup _from_ imperatives (this was already the case) and _from_ the config So, we move out the config bits from table and make it work with the generic interface. Just as we already tested table setup from imperatives, this will let us test the same through cfg as well. (see next commit) While we're at it: * move imperative's table Interface and MockTable to the table package, so it can be used in various places * cleaner "TableConfig" type * move validation of badMetrics settings and its creation to table config and construction (that was the only case from the moved config stuff that accessed the table directly and couldn't be interface-ized) One interesting thing is that the cfg imports imperatives. Why? simply because your toml configuration may contain imperative commands that need to be executed
Dieterbe
changed the title
fkaleo
approved these changes
Jun 15, 2021
|
for anyone lurking...
i figured it out how to do it. pretty happy now to have unit testing both from the toml config, as well as imperatives side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fkaleo i got a bit of a surprise for you..
I thought it was a good idea to refactor that ugly-and-getting-longer constructor function for GrafanaNet routes to use a cfg struct. added some options, so far so good.
thought it may also make sense to add some testing to make sure that 1) given an init command or 2) given a toml config, the proper grafananet route is created. but both of those affect the table directly, so you have to inspect the table (or use a mock that makes it a bit easier). for use case 1 it was fairly straightforward, but 2 landed me in a bit of a mess (circular dependency) . I'll have a fresh look at it on monday. i still like the idea of unit testing, but need to figure out if it can be done realistically
well at least even without the tests, this PR does clean stuff up, both in code and docs.