improvements to grafanaNet route schemas posting + post storage aggregations #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dieterbe
force-pushed
the
grafana-net-config-posting
branch
from
52e58da
to
b6a3aaf
Compare
BEFORE: POST / HTTP/1.1. Host: localhost:8080. User-Agent: Go-http-client/1.1. AFTER: POST / HTTP/1.1. Host: localhost:8080. User-Agent: Carbon-relay-NG / 0.14.0-15-g808b038e.
Dieterbe
force-pushed
the
grafana-net-config-posting
branch
from
e8eb3c8
to
49ad21e
Compare
note: pretty much requires validation that configured address ends on /metrics
Dieterbe
force-pushed
the
grafana-net-config-posting
branch
from
49ad21e
to
4ce003b
Compare
this will help with troubleshooting schemas or bad metrics
minus the files we don't need: indexrules.go indexrules_test.go init.go retention.go retention_test.go schemas.go schemas_test_files schemas_test.go
our configparser library will happily take a file that contains just prose and no ini data at all, and consider it a valid file, which would result in us using the default aggregation rules, which may be a user mistake we'd silently cover up. So as a caller of it, be a bit more assertive.
Dieterbe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note that the storage-aggregation.conf file is now mandatory, which is a breaking change and requires a major new version release (0.15)
fix #463