Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error messages, especially for storage-aggregation.conf #470

Merged
merged 1 commit into from Jul 7, 2021

Conversation

Dieterbe
Copy link
Contributor

@Dieterbe Dieterbe commented Jul 7, 2021

fix #469

BEFORE:
2021-07-01 22:49:45.813 [ERROR] NewGrafanaNetConfig: could not read aggregationFile "": read .: is a directory
2021-07-01 22:49:45.815 [ERROR] error adding route 'grafanaNet'

AFTER:

2021-07-07 15:01:52.567 [ERROR] NewGrafanaNetConfig: invalid value for 'aggregationFile'. value must be set to the path to your storage-aggregation.conf file
2021-07-07 15:01:52.567 [INFO] grafanaNet route configuration details: https://github.com/grafana/carbon-relay-ng/blob/master/docs/config.md#grafananet-route
2021-07-07 15:01:52.567 [ERROR] error adding route 'grafanaNet'

BEFORE:
2021-07-01 22:49:45.813 [ERROR] NewGrafanaNetConfig: could not read aggregationFile "": read .: is a directory
2021-07-01 22:49:45.815 [ERROR] error adding route 'grafanaNet'

AFTER:

2021-07-07 15:01:52.567 [ERROR] NewGrafanaNetConfig: invalid value for 'aggregationFile'. value must be set to the path to your storage-aggregation.conf file
2021-07-07 15:01:52.567 [INFO] grafanaNet route configuration details: https://github.com/grafana/carbon-relay-ng/blob/master/docs/config.md#grafananet-route
2021-07-07 15:01:52.567 [ERROR] error adding route 'grafanaNet'
@Dieterbe Dieterbe merged commit 07c554f into master Jul 7, 2021
@Dieterbe Dieterbe deleted the improve-schemasFile-aggregationFile-error-msg branch July 7, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better handling when aggregationFile isn't defined
1 participant