Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jsonnet lib to work with latest Tanka version #487

Merged
merged 2 commits into from Mar 4, 2022

Conversation

fionaliao
Copy link
Contributor

The default k8s library used by Tanka was changed in grafana/tanka#563. This meant the k8s instructions didn't work with the latest version of Tanka (v0.20); I was seeing an error like:

$ tk show environments/default/
Error: evaluating jsonnet: RUNTIME ERROR: Attempt to use super when there is no super class.
        /.../crng-tanka-check/vendor/github.com/jsonnet-libs/k8s-libsonnet/1.20/_custom/apps.libsonnet:35:7-12 function <anonymous>
        /.../crng-tanka-check/vendor/ksonnet-util/grafana.libsonnet:45:9-57    function <anonymous>
        /.../crng-tanka-check/vendor/carbon-relay-ng/crng.libsonnet:62:5-94    object <anonymous>
        Field "carbon_relay_ng_deployment"
        Field "crng"
        During manifestation

This PR updates the carbon-relay-ng jsonnet lib so it'll work with the updated k8s library, and also makes a small update to the k8s doc.

Testing

Followed the k8s instructions to set up the Tanka environment, ran tk show environments/default, which worked after I'd made changes to the jsonnet library.

The default k8s library used by Tanka was changed. This meant that the
carbon-relay-ng jsonnet library didn't work with the latest version of
Tanka (v0.20).

Signed-off-by: Fiona Liao <fiona.y.liao@gmail.com>
Signed-off-by: Fiona Liao <fiona.y.liao@gmail.com>
@Dieterbe Dieterbe merged commit cb9d8c5 into master Mar 4, 2022
@Dieterbe Dieterbe deleted the fl/crng-tanka-update-fix branch March 4, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants